search

KonradLinkowski / Nostalgia

Small Progressive Web App to store your notes made in Svelte
https://konradlinkowski.github.io/Nostalgia
MIT License
3 stars 2 forks source link

Add confirm dialogue for "Clear Memories" #9

Closed IanFindlay closed 3 years ago

IanFindlay commented 3 years ago

Fixes issue #8 - Similar to the 'delete memory' confirmation dialogue but with two buttons: "Confirm" and "Cancel".

KonradLinkowski commented 3 years ago

I forgot that there is confirm dialog for the delete button

IanFindlay commented 3 years ago

Yeah the code duplication didn't sit right with me either. I'm not well versed enough with Svelte to know how to do things the way I think they should be done and, having been unable to get this confirm dialogue working for the other PR, was quite pleased to get it working even if it isn't an ideal implementation.

I'm sort of poking around and seeing what I can accomplish and learn with this project so if anything I do isn't the right way to do it know that I won't take offence if my PR doesn't get merged and that I appreciate you setting a standard that I can learn from. I'm going to read into actions and things surrounding them, but it is quite possible implementing something like that is a bit beyond me for now; if you end up making it, I look forward to seeing how you've done it and learning from that.