KorAP / Kalamar

:octopus: Mojolicious-based Frontend for KorAP
BSD 2-Clause "Simplified" License
7 stars 2 forks source link

Plugin: Tooltip-text is taken as the button label #224

Closed Bodmo closed 3 weeks ago

Bodmo commented 1 month ago

When adding a Plugin as a toggle button to the query panel, the 'title' property of the plugin is taken for the label of the button. Instead, I suppose that the 'name' property should be taken.

Screenshot 2024-10-25 at 18-51-10 KorAP Finde »Kirchturm beim« mit Cosmas II

Akron commented 1 month ago

As far as I can see, the embeddings don't have a name property. name is only available on the plugin level, so title is correct. We may want to introduce a desc property, if you want to add more information. I can see why title is confusing, as it isn't the same as the HTML attribute.

Bodmo commented 1 month ago

Yes, exactly, I thirst thought 'title' is taken from HTML. For the moment, we have only 1 property for 2 purposes: a. a very short button label, and b. a longer description for the tooltip. 'desc' is already a property of the plugin. Do you mean it is possible to add a 'desc' property on the embedding level?

Akron commented 1 month ago

Yes, I think that's possible.

Akron commented 3 weeks ago

I added desc support for widgets in Gerrit.