search

KostaSav / hp-api

A simple JSON-based API for getting information on Harry Potter characters.
203 stars 86 forks source link

Added Newt's details and some other things #69

Closed SunSummoner closed 1 year ago

SunSummoner commented 1 year ago

Added Newt's details and Dennis's full name https://harrypotter.fandom.com/wiki/Newton_Scamander#Hogwarts_years_(1908%E2%80%931913?) https://harrypotter.fandom.com/wiki/Dennis_Creevey

KostaSav commented 1 year ago

@SunSummoner kind reminder for the requested changes above.

Better do a separate pull request for a different change - for the images, I prefer to upload them on imagekit currently, and pinterest does not allow me to download the image.

SunSummoner commented 1 year ago

Hi @SunSummoner ,

There is already an entry for Dennis Creevey (currently on line 5107). The one you edited is Dudley's friend (fandom link).

Can we also follow the convention, uppercase for house and lowercase for eyeColour, hairColour, etc?

Please edit your commit and do a new pull request. 😃

I'm sorry for that. I wasn't aware about the convention. I'll do a new a pull request.