RPM cleanup for Fedora and some changes to stability of the script

[magikmw]

Hi,

Thanks for creating this script, I never considered converting .deb packages to rpm directly. Since I dislike piping wget/curl output directly to bash, I've run the commands one by one and discovered there's some improvements I could make.
Here's a list of changes:

• I've applied rpmrebuild package to clear up conflicts the converted package had with filesystem package on Fedora. After the change we're able to use more idiomatic dnf packager for installation instead of directly via rpm.
• Above required some control flow changes to the script, I've also added a note to Fedora users that they can safely remove alien and rpmrebuild.
• Rest of the commits are changes are general bash improvements (thanks to shellcheck):
  • Remove redundant cat command (we can directly grep a file)
  • Ensure the cd command runs in some freak accident where our directories are unavailable.

I haven't touched the Opensuse part of the script, since I don't have that system on hand for testing. Let me know if you'd like to do anything different.

[Kozova1]

Was this tested? if yes I'll be happy to merge. thank you for contributing?

[magikmw]

Well, I ran it on my laptop :) I'll setup a clean Fedora in a VM tomorrow and try it out to make sure nothing breaks in a controlled environment. Nonetheless I've ran those commands one by one and that's how it's setup on my laptop.

[Kozova1]

great, I will merge it into a new branch until either you or I confirm it is working on a clean machine, and then I'll move it to the main one. good job!

[magikmw]

So I did a test, and indeed I messed up the conditional check for OpenSUSE. It's fixed up over at my fork, but since you already merged this pull request I cannot create a new one with all changes or amend this one. Not sure what to do. Commit in question is here: https://github.com/magikmw/parsec-fedora/commit/ed69d2d2af2e9d894680b26ef4a3fea1e70ad3ae

Otherwise, it works!