is here a potential bug?

[dustincys]

Hi, @scottgigante

here: https://github.com/KrishnaswamyLab/MAGIC/blob/master/python/magic/magic.py#L830

is it right t_opt = i

instead of t_opt = i + 1 ?

[scottgigante]

Thanks for checking! This is actually as designed -- the heuristic stops with t one higher than where the error drops below the threshold. This doesn't break the loop, so when we set t_opt it just runs the loop once more.

[dustincys]

Thank you for quick reply. I don't think that will runs the loop once more.

In the "last" loop, at the beginning, while here, i == t_opt -1, next, after here i == t_opt, if error < threshold , then here, i == t_opt-1 again.

until error > threshold.., I see. Thank you.

[scottgigante]

Thanks for checking! Line 829's and t_opt is None ensures that line 830 won't be run more than once, I believe.

[dustincys]

Thank you @scottgigante , that's right.