search

Kuadrant / authorino-operator

Kubernetes Operator to manage Authorino instances
Apache License 2.0
9 stars 21 forks source link

Namespace support. #134

Closed Boomatang closed 11 months ago

Boomatang commented 1 year ago

Closes #41

codecov-commenter commented 1 year ago

Codecov Report

Merging #134 (8659e32) into main (b03fcf4) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   63.11%   63.11%           
=======================================
  Files           1        1           
  Lines         732      732           
=======================================
  Hits          462      462           
  Misses        220      220           
  Partials       50       50
Flag Coverage Δ
unit 63.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

guicassolato commented 1 year ago

In general, I think the changes here are welcome for the developer workflow, i.e., the one where you clone the repo, make local changes, and want to try them out by rebuilding and deploying to an almost always local cluster, whilst switching the namespace to something other than the default authorino-operator.

For the non-OLM user workflow nonetheless, i.e., the one by which the operator is installed by simply applying the pre-build manifests (without cloning the repo, without custom build of the binary or container image), it's a step forward, but likely won't suffice. For that, we may need to incorporate some of the changes here into the install script to be introduced with https://github.com/Kuadrant/authorino-operator/pull/137.

I'm thinking a possible subsequent step after merging both PRs would be making the install script to rely as well on kustomize, to rebuild the manifests "on-the-fly" including an optional custom namespace. MGC team did sth similar with https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/hack/quickstart-setup.sh.