Kuadrant / authorino-operator

Kubernetes Operator to manage Authorino instances
Apache License 2.0
9 stars 20 forks source link

Fix bundle build workflow #153

Closed adam-cattermole closed 1 year ago

adam-cattermole commented 1 year ago

Porting of the changes from https://github.com/Kuadrant/authorino-operator/tree/v0.9.0 to fix the release workflow and manifests building.

adam-cattermole commented 1 year ago

Sure latest commit added where I ran make manifests bundle CHANNELS=stable DEFAULT_CHANNEL=stable

adam-cattermole commented 1 year ago

Actually, maybe I should set CHANNELS?=stable by default in the Makefile, the default with --overwrite behaviour from operator-sdk is to set it to alpha when not defined

adam-cattermole commented 1 year ago

Oh maybe the same should be true for DEFAULT_CHANNEL - verify fails as it does not set either of these by default

codecov-commenter commented 1 year ago

Codecov Report

Merging #153 (f5ff784) into main (aee73cf) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   62.85%   62.85%           
=======================================
  Files           1        1           
  Lines         735      735           
=======================================
  Hits          462      462           
  Misses        222      222           
  Partials       51       51           
Flag Coverage Δ
unit 62.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

adam-cattermole commented 1 year ago

I have changed the behaviour to default to alpha on the main branch. When we provide the DEFAULT_CHANNEL and CHANNELS as part of the release workflow the bundle.Dockerfile and bundle annotations will be updated to the correct channels.

If we want to build catalogs from main branch and test the upgrade from a previously released bundle version we need to specify stable for the channels above when building the bundle from main.