Kuadrant / authorino-operator

Kubernetes Operator to manage Authorino instances
Apache License 2.0
9 stars 20 forks source link

fix: ignore template diffs when verifying manifests #207

Closed guicassolato closed 2 months ago

guicassolato commented 2 months ago

Make the manifest/bundle verification to ignore changes to the authorino kustomization file. The changes to the manifests are the ones that actually matter, not the ones to the template/kustomization file.

Fixes: https://github.com/Kuadrant/authorino-operator/actions/runs/10716422467/job/29715385421

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.78%. Comparing base (e26e1f3) to head (4121628).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #207 +/- ## ======================================= Coverage 61.78% 61.78% ======================================= Files 2 2 Lines 785 785 ======================================= Hits 485 485 Misses 249 249 Partials 51 51 ``` | [Flag](https://app.codecov.io/gh/Kuadrant/authorino-operator/pull/207/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/Kuadrant/authorino-operator/pull/207/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `61.78% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikenairn commented 2 months ago

Question: Why would we want to have manifests and a bundle on a branch/tag of this repo that do not have the correct image refs?