search

Kuadrant / kuadrant-operator

The Operator to install and manage the lifecycle of the Kuadrant components deployments.
Apache License 2.0
35 stars 32 forks source link

Create label to trigger Quay images job #241

Open didierofrivia opened 1 year ago

didierofrivia commented 1 year ago

Currently we're facing mainly 2 issues:

  1. Images overflow in our quay.io repo
  2. Pull requests coming from forks cannot trigger the build and push of the images

It would be good to have a label or a comment that administrators of Kuadrant org can assign to any PR in order to allow the trigger of the required quay job.

This needs to be applied to every Kuadrant repo.

Something that's been used by k8s that could be of help is https://prow.k8s.io/command-help#ok_to_test.

Boomatang commented 1 year ago

I am not sure how much the ok_to_test label that k8s uses will help. K8s uses prow and not github actions. I am not say that github actions can't do the same, its more any prow feature would need to be researched to find the equivalent github action feature. A scan of https://github.com/marketplace/actions/label-actions shows that it is possible to do the triggers on labels. If it is enough for what we want, that is a different question.

alexsnaps commented 9 months ago

@didierofrivia is this still relevant in the light of the upcoming RFC?

didierofrivia commented 9 months ago

I'd say it is, since the RFC even if it's finished before the holidays, after reviewing and adjustments, it most probably will end up being implemented in March.