Split sound into keydown and keyup portions

[binarybana]

I wanted to put a draft PR up since this has bigger changes in functionality, and will require pre-processing of soundpacks in order to support the new format.

What this PR does:

• Introduces a new utility script to iterate through a soundpack, analyze the ogg files, split them into the key-up and key-down portions, trim silent whitespace off the front edge (to further reduce delay), and then save out as wav files.
• Modify the main rustyvibes driver to play the appropriate key down and key up sounds at the right time.

Gaps/deficiencies in this current PR

• Rust ogg encoder crates are few and far between, so here for simplicity I'm writing out to wav instead.
• I need to clean up and improve the conversion script to also modify the config.json as well, and delete the original ogg files.
• The usage of up.wav extension is a bit of a hack, but avoids me from having to do more major surgery to the config schema.

I'd like to know if this is a direction I should keep pursuing before continuing though. So what do you think?

In trying it out, I think it's pretty flippin' sweet to hear an accurate key down and key up sound at the right times. Really makes it feel realistic. But that's just my $0.02.

[KunalBagaria]

Thank you

Hi, first of all, thank you so much for taking to so much time to contribute to this open-sourced project, I really appreciate it. And yes, you should keep pursuing in this direction, you are single-handedly making rustyvibes so much better.

[binarybana]

Great to hear! I'll keep at it then.

[KunalBagaria]

You can spawn a ffmpeg child process to split the audio files and convert wav into ogg

[binarybana]

Yes, good point to add as another limitation to work around.

Also, a broader question I was thinking about: should the audio conversion utilities be built into the main rustyvibes binary itself? Otherwise, you're going to have to distribute two different binaries, one for pre-processing key packs. I think the downside is that it'll be a slightly larger binary with more dependencies.

On Thu, Oct 7, 2021 at 10:33 PM Kunal Bagaria @.***> wrote:

Also, I saw that up.wav was hardcoded, so the extension would be dynamic for other audio formats like ogg right?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kb24x7/rustyvibes/pull/15#issuecomment-938357187, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC75DQE4IYAW7MJW7BDS33UFZ7BNANCNFSM5FSYMXMQ .

[KunalBagaria]

I think it would be better to keep separate binaries since most of the normal users won't notice / care it. Also, I refactored some code into multiple files so you might have some merge issues.