search

KunalBagaria / rustyvibes

A Rust CLI that makes mechanical keyboard sound effects on every key press
https://github.com/kunalbagaria/rustyvibes
MIT License
208 stars 26 forks source link

Add volume support to cli #24

Closed aasutossh closed 1 year ago

aasutossh commented 1 year ago

rustyvibes <volume> <soundpack_path>

Maybe need to update the readme too? Either update the source in cargo or instruction to build it locally.

aasutossh commented 1 year ago

closes #22 #20

KunalBagaria commented 1 year ago

Thank you so much for the PR, let me review it this week and merge.

aasutossh commented 1 year ago

let me know if anything needs to be improved. have never used rust before.

aasutossh commented 1 year ago

Could you provide some insights on how to achieve those actions without unsafe?

KunalBagaria commented 1 year ago

You can refer to #25