search

KundaPanda / strawberry-django-jwt

[UNMAINTAINED] JSON Web Token (JWT) authentication for Django with Strawberry GraphQL
MIT License
37 stars 16 forks source link

Fixes from https://github.com/nrbnlulu, dependency and config updates #329

Closed KundaPanda closed 2 years ago

KundaPanda commented 2 years ago

This is a cherry-picked PR from @nrbnlulu 's #326.

Fix for strawberry warnings, updated dependencies, changed configurations of some tools, reformatted.

codecov[bot] commented 2 years ago

Codecov Report

Merging #329 (b8a0a11) into master (e7f920c) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #329   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines         1100      1066   -34     
  Branches       181       177    -4     
=========================================
- Hits          1100      1066   -34
Impacted Files Coverage Δ
...trawberry_django_jwt/refresh_token/object_types.py 100.00% <ø> (ø)
strawberry_django_jwt/auth.py 100.00% <100.00%> (ø)
strawberry_django_jwt/backends.py 100.00% <100.00%> (ø)
strawberry_django_jwt/decorators.py 100.00% <100.00%> (ø)
strawberry_django_jwt/middleware.py 100.00% <100.00%> (ø)
strawberry_django_jwt/mixins.py 100.00% <100.00%> (ø)
strawberry_django_jwt/model_object_types.py 100.00% <100.00%> (ø)
strawberry_django_jwt/mutations.py 100.00% <100.00%> (ø)
strawberry_django_jwt/object_types.py 100.00% <100.00%> (ø)
...awberry_django_jwt/refresh_token/admin/__init__.py 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7f920c...b8a0a11. Read the comment docs.

nrbnlulu commented 2 years ago

@KundaPanda What is left to be done here? And can i close the other PR?

KundaPanda commented 2 years ago

@KundaPanda What is left to be done here? And can i close the other PR?

Nothing, just wanted to wait if you have any additional inputs about the things I had written in your PR.

nrbnlulu commented 2 years ago

Not really this was just a maintenance PR nothing else..

nrbnlulu commented 2 years ago

@KundaPanda Lets merge this! :tada:

nrbnlulu commented 2 years ago

BTW I have migrated the graphql-django-auth from graphene that relied on grahpql-djanngo-jwt so you will hear from me a lot :smile:

KundaPanda commented 2 years ago

BTW I have migrated the graphql-django-auth from graphene that relied on grahpql-djanngo-jwt so you will hear from me a lot 😄

Absolutely, with more feedback, I will pay more attention to this project!