search

LANDIS-II-Foundation / Extension-Base-Fire

Base Fire extension for LANDIS-II
https://sites.google.com/site/landismodel/extensions/base-fire
Apache License 2.0
1 stars 5 forks source link

Registered site variable TimeOfLastFire should be TimeOfLastEvent #12

Closed brmiranda closed 5 years ago

brmiranda commented 7 years ago

A RegisteredSiteVar has been added to Base Fire called TimeOfLastFire. However, to be consistent with other extensions, the name should be TimeOfLastEvent. Dynamic Fire, Base Wind, Linear Wind and Base and Biomass Harvest all use the naming convention of DisturbanceType.TimeOfLastEvent for the RegisteredSiteVars. This enables other extensions to be compatible across different extensions of the same type.

For example an extension that wants to use the information about the last fire event should be able to refer to Fire.TimeOfLastEvent and it should work whether the user ran Base Fire or Dynamic Fire. Currently, the other extension would have to try loading both Fire.TimeOfLastEvent and Fire.TimeOfLastFire and check which one worked to be compatible with both versions of fire.

aruzicka555 commented 7 years ago

Name changed, pull request submitted to Bruce.