LCAS / topological_navigation

The topological navigation framework
Apache License 2.0
38 stars 37 forks source link

Taking out bayesian_topological_localisation #178

Closed francescodelduchetto closed 9 months ago

francescodelduchetto commented 9 months ago

The localisation package is now at https://github.com/LCAS/bayesian_topological_localisation

Iranaphor commented 9 months ago

Were there any files in topological_navigation_msgs which should be isolated along with this?

francescodelduchetto commented 9 months ago

Were there any files in topological_navigation_msgs which should be isolated along with this?

I believe not. Messages and services definitions are https://github.com/LCAS/topological_navigation/tree/master/bayesian_topological_localisation/msg and https://github.com/LCAS/topological_navigation/tree/master/bayesian_topological_localisation/srv

francescodelduchetto commented 9 months ago

Were there any files in topological_navigation_msgs which should be isolated along with this?

I believe not. Messages and services definitions are https://github.com/LCAS/topological_navigation/tree/master/bayesian_topological_localisation/msg and https://github.com/LCAS/topological_navigation/tree/master/bayesian_topological_localisation/srv

Ah no actually, you are right....with the move to humble also these definitions have been moved it seems...

francescodelduchetto commented 9 months ago

@Iranaphor, please check it's all correct now.

Iranaphor commented 9 months ago

That was my only thought, with the humble transition I figured tighter integration would be beneficial. Im happy.

marc-hanheide commented 9 months ago

still test fails as messages are referenced that are no longer there, right?

marc-hanheide commented 9 months ago

see https://github.com/LCAS/topological_navigation/actions/runs/7505325308/job/20441251372#step:5:179

marc-hanheide commented 9 months ago

removed the building of the no longer existing messages

marc-hanheide commented 9 months ago

@Iranaphor you also happy? If so, let's merge.