LGUG2Z / komorebi-application-specific-configuration

A central place to document all tweaks required for Komorebi to 'just work' with as many applications as possible
MIT License
69 stars 52 forks source link

ignore rules for Microsoft Visual Studio Community 2022 #115

Closed CtByte closed 2 weeks ago

CtByte commented 2 weeks ago

@LGUG2Z I have expanded on the ignore rules for Visual Studio.

I am not 100% sure if the composite rules need to include the match on Exe

{
  "kind": "Exe",
  "id": "devenv.exe",
  "matching_strategy": "Equals"
}

But let's see what you say 🤔

LGUG2Z commented 2 weeks ago

Looks good! I think when matching on Title it's good to use a composite rule with Exe to reduce the blast radius.

alex-ds13 commented 2 weeks ago

@CtByte @LGUG2Z Couldn't these ignore windows be set to floating? As far as I understand these are some sort of popup windows that need to be floating right? Or are they internal windows of visual studio that stay inside it when ignored?

Because if they are floating windows, we could use the floating so that they are still bound to the same workspace instead of showing on all workspaces like they do when ignored...

CtByte commented 2 weeks ago

@alex-ds13 From what I remember when adding these rules, most of these are for loading windows, search windows, confirmation popups and such. I would not mind if they are floating, I just did not think these should be managed at all.

If they are managed, would they also have the "komorebi-drawn" borders?

alex-ds13 commented 2 weeks ago

If they are managed, would they also have the "komorebi-drawn" borders?

If you want to they can. Or you can set the floating border to 0x000000 which will make them invisible. In that case the only difference would be that if you changed workspace while one of those windows was opened, then that window would be "cloaked"/"hidden" like all other managed windows and when you move back to that workspace again it would show up again...

CtByte commented 2 weeks ago

I can see the benefit in that, it might feel cleaner if the popups belong to the workspace. One of the windows is a "transparent placeholder" so at least that should be ignored. The confirmation and popup windows could be floating.

But let's see what Jeezy thinks.

LGUG2Z commented 2 weeks ago

My gut feeling is:

If it only gets popped up to be immediately clicked away (confirmations etc.) -> ignore rule

If it gets popped up, stays open and is interacted with for a while before being closed -> floating rule

But I'm open to having my mind swayed!

CtByte commented 2 weeks ago

ok, I guess this will be the first one to have floating rules 😅

  "Visual Studio": {
    "object_name_change": [
      {
        "kind": "Exe",
        "id": "devenv.exe",
        "matching_strategy": "Equals"
      }
    ],
    "floating": [
      // floating rules
    ],
    "ignore": [
      // ignore rules
    ]
  },

EDIT: I will test my application.json locally first to see if having the border for floating windows is annoying 😅 I will come back with an update at the end of my workday

alex-ds13 commented 2 weeks ago

EDIT: I will test my application.json locally first to see if having the border for floating windows is annoying 😅 I will come back with an update at the end of my workday

You can always make the borders invisible like I've mentioned before. Also I've noticed that when using floating windows, when they lose focus the border seems to be removed and it only shows up again if you move or resize the window...

CtByte commented 2 weeks ago

I've found the floating windows having the border to be nice, if I am honest, but the border disappears for me too when the window lost focus.

https://github.com/user-attachments/assets/5a966424-efe8-4e9d-894b-e413d17e0b5a