Closed cirehtheterrible closed 1 year ago
Thanks for this @cirehtheterrible! I actually just pushed a commit for the Steam Beta issue before checking this PR so that can be dropped from here. As for Signal, depending on how it is installed it can have either an upper or lowercase S; for this I think the best thing we can do is just duplicate the entry with the other case. If you can make these changes let's get this PR merged in today. 🤞
Should I remove the Steam tiling behavior as well? I don't know if you have any guidelines to follow when making the custom settings, but, to me at least, it felt more natural to only have the main steam window tile, while the Settings, Logging in and "Shutting down" windows would float.
- name: Steam Beta - float_rule
identifier:
kind: title
id: Steam
options:
- force
float_identifiers:
- kind: exe
id: steamwebhelper.exe
You can remove this from the PR as it's now covered here, then you just need to duplicate the Signal entry for the uppercase exe name 👌
As for Signal, depending on how it is installed it can have either an upper or lowercase
@LGUG2Z I'm guessing you installed Signal through Scoop 😅. Even inside the installer, Signal.exe
is capital case. This should be fixed upstream to the Extras bucket: https://github.com/ScoopInstaller/Extras/commit/d9f9efbbfd15b91001d8099bc7a07b19304ae76d
Updated the rule as well: https://github.com/LGUG2Z/komorebi-application-specific-configuration/commit/bad95ddfcf09d15e3280fadce3b13b95a6599a1d. Now maybe we don't need this PR anymore?
May I ask what is the correct way to implement this? Is there a way to pair the title
identifier to a specific .exe? I settled on this approach because even though the "Steam Settings" and "Steam Controller Configs" windows have "Steam" in them, they didn't get tiled.
Is there a way to pair the
title
identifier to a specific .exe?
There isn't such functionality for now. I recommend opening an issue on the komorebi repo for that, though. It's a good idea.
Makes only the main Steam window tile. Also fixes a quirk, where the "Your friend is now playing..." window would re-tile the screen. Fixes Signal.exe not closing properly.
applications.yaml
withkomorebic fmt-asc
.