LGUG2Z / komorebi

A tiling window manager for Windows 🍉
https://lgug2z.github.io/komorebi/
Other
9.58k stars 198 forks source link

Fix(wm): update monitor focus before focus-stack-window #1034

Closed alex-ds13 closed 1 month ago

alex-ds13 commented 1 month ago

This commit fixes the cases where you'd call this command on a monitor which was not focused, for example by pressing a button on a bar like komorebi-bar or other when you had focus on another monitor. This change ensures that first we focus the monitor where the mouse cursor is, this way it will act on the monitor that you've just pressed instead of the monitor that was focused before.

LGUG2Z commented 1 month ago

Good catch! Can amend and force push the commit message to match the repo format? eg fix(wm): update monitor focus before focus-stack-window - this will ensure the changelog generation for the next release is smooth

alex-ds13 commented 1 month ago

Good catch! Can amend and force push the commit message to match the repo format? eg fix(wm): update monitor focus before focus-stack-window - this will ensure the changelog generation for the next release is smooth

Sure thing. Do you want me to reword the explanation part of the commit too? I also found it confusing when writing it 😅

LGUG2Z commented 1 month ago

Explanation is all good, the changelog generator only looks at the format of the first line 🤞

alex-ds13 commented 1 month ago

Done!