LGUG2Z / komorebi

A tiling window manager for Windows 🍉
https://lgug2z.github.io/komorebi/
Other
9.59k stars 198 forks source link

[BUG]: Reloading config loses stackbar #792

Closed tgrosinger closed 6 months ago

tgrosinger commented 6 months ago

Describe the bug

I know the stackbar is in beta, but I'm excited about this feature and have been trying it out. It's generally working really well, but there are a couple scenarios where it disappears. The one I have run into most so far is when the configuration is reloaded.

To Reproduce Steps to reproduce the behavior:

  1. Enable stackbar in config (shown below)
  2. Launch Komorebi and create a stack. Stackbar is shown as expected.
  3. Make a change to Komorebi config, causing it to automatically reload.
  4. Stackbar disappears. Must stop and restart Komorebi for it to appear again.

Operating System

OS Name:                   Microsoft Windows 11 Pro
OS Version:                10.0.22631 Build 22631

komorebic check Output

PS C:\Users\tgrosinger> komorebic check
No KOMOREBI_CONFIG_HOME detected, defaulting to C:\Users\tgrosinger

Looking for configuration files in C:\Users\tgrosinger

Found komorebi.json; this file can be passed to the start command with the --config flag

Found C:\Users\tgrosinger\.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag

Additional context

  "stackbar": {
    "height": 30,
    "mode": "OnStack",
    "tabs": {
      "width": 200,
      "focused_text": "#00a542",
      "unfocused_text": "#b3b3b3",
      "background": "#141414"
    }
  },
tgrosinger commented 6 months ago

Oh actually it seems like the stack bar comes back if you add something to the stack again.

LGUG2Z commented 6 months ago

I think this looks like another way to produce the stackbar visibility issues that have been reported here: https://github.com/LGUG2Z/komorebi/issues/746

I'll close out this issue and pin #746 to try and keep all of the brainstorming in one place and hopefully attract some smarter minds to help solve this annoying bug.