search

LHCfitNikhef / smefit_release

SMEFiT a Standard Model Effective Field Theory fitter
GNU General Public License v3.0
6 stars 1 forks source link

update version of pyyaml #55

Closed tgiani closed 1 year ago

tgiani commented 1 year ago

this should fix the installation of the current main (which has still NS). @giacomomagni @jacoterh could you please try to run install.sh and see if it works for you?

tgiani commented 1 year ago

@giacomomagni thank you. Do you understand why the test are failing? Some test about the fisher is not passing, not sure what happened with that?

giacomomagni commented 1 year ago

@giacomomagni thank you. Do you understand why the test are failing? Some test about the fisher is not passing, not sure what happened with that?

I don't remember as well, but they are failing also in master, so it's unrelated to this. I'm investigating it now.

giacomomagni commented 1 year ago

I don't remember as well, but they are failing also in master, so it's unrelated to this. I'm investigating it now.

Not sure why the fix was 61023e399b94346bcf3256c98e99a2a1672d1d1a, I'm not sure that test has any meaning ...

codecov[bot] commented 1 year ago

Codecov Report

Merging #55 (f071827) into main (a81937f) will not change coverage. Report is 25 commits behind head on main. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   43.20%   43.20%           
=======================================
  Files          27       27           
  Lines        2185     2185           
=======================================
  Hits          944      944           
  Misses       1241     1241
Flag Coverage Δ
unittests 43.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/smefit/analyze/pca.py 68.15% <ø> (ø)
src/smefit/chi2.py 38.88% <ø> (ø)
src/smefit/fit_manager.py 67.27% <ø> (ø)
src/smefit/loader.py 91.87% <100.00%> (ø)
src/smefit/optimize/mc.py 52.57% <ø> (ø)
src/smefit/optimize/ns.py 61.53% <ø> (ø)
tgiani commented 1 year ago

thank you! uhm if the test is meaningless we can just remove it? A part from this I guess this can be merged?

giacomomagni commented 1 year ago

thank you! uhm if the test is meaningless we can just remove it?

Probably yes, but as long as it's passing let's keep it..., what confuses me is that to make it passing I had to set use_multiplicative_prescription=True only in one of the 2 objects..

A part from this I guess this can be merged?

yes thanks.