Fixes for RDMA - Githubissues

mtisza commented 1 year ago

I've spent some time debugging issues with RDMA. Without these patches RDMA did not work at all (crashes, hangs, random ping timeouts, ...). After these patches it works quite well.

This does resolve https://github.com/LINBIT/drbd/issues/58, as well as other issues.

This might seem like a duplicate of https://github.com/LINBIT/drbd/pull/65, but there was an issue I failed to detect on that one prior to submitting it (build issue due to rebasing onto latest master).

LinbitPRBot commented 1 year ago

Hi @mtisza!

Thanks for your contribution to the LINBIT software!

Development for this project happens on mailing lists, rather than on GitHub - this GitHub repository is a read-only mirror that isn't used for accepting contributions. So that your change can become part of our software, please email it to us as a patch.

Here's what to do:

Format your contribution
Decide where to send your contribution to
Set up your system to send your contribution as an email
Send your contribution and wait for feedback

How do I format my contribution?

Firstly, all contributions need to be formatted as patches. A patch is a plain text document showing the change you want to make to the code, and documenting why it is a good idea.

You can create patches with git format-patch.

Secondly, patches need 'commit messages', which is the human-friendly documentation explaining what the change is and why it's necessary.

Who do I send my contribution to?

There are two mailing lists:

DRBD-dev is "strictly" used for patch coordination.
DRBD-user is also fine to send your ideas and initals "RFC" patches. You probably want to start here.

If you're interested in DRBD development, subscribing to these mailing lists is a good idea.

How do I send my contribution?

Use git send-email, which will ensure that your patches are formatted in the standard manner. In order to use git send-email, you'll need to configure git to use your SMTP email server.

For more information about using git send-email, look at the Git documentation or type git help send-email. There are a number of useful guides and tutorials about git send-email that can be found on the internet.

How do I get help if I'm stuck?

Firstly, don't get discouraged, we are here to help! If you are lost in the process, and really tried, you will usually find contact information in header/implementation files, or see who touched the code with git blame. If it was an @linbit.com person, write to them. We are more interested in good patches than strictly following the rules (but you should try first!).

I sent my patch - now what?

You wait.

You can check that your email has been received by checking the mailing list archives for the mailing list you sent your patch to. Messages may not be received instantly, so be patient. Developers are generally very busy people, so it may take a few days, even weeks before your patch is looked at.

Then, you keep waiting. It is fine to kick us again if you did not receive an answer within 2 weeks, but usually we are a lot faster.

Further information

This is a good read in general, escpecially if you touched the kernel parts of DRBD: Working with the kernel development community - the official documentation for new kernel contributors

Happy hacking!

This message was posted by a bot - if you have any questions or suggestions, please talk to my owner, @rck