search

LLNL / SSAPy

A Python package allowing for fast and precise orbital modeling.
https://software.llnl.gov/SSAPy/
MIT License
36 stars 8 forks source link

Run and upload coverage tests #25

Open rusu24edward opened 2 months ago

rusu24edward commented 2 months ago

Resolves #5 Resolves #14

aperloff commented 2 months ago

@rusu24edward, there is a test failing and some conflicts. Once you fix those I will review. Thank you.

rusu24edward commented 2 months ago

I resolved the conflict. I believe the failing test is a result of me adding the test suite to the CI, which is expected to fail until we resolve #18 and #37

rusu24edward commented 2 months ago

Actually, the failure is this:

ERROR: usage: __main__.py [options] [file_or_dir] [file_or_dir] [...]
__main__.py: error: unrecognized arguments: -n ./tests/
  inifile: /home/runner/work/SSAPy/SSAPy/setup.cfg
  rootdir: /home/runner/work/SSAPy/SSAPy

I've run into this a few times running the test suite. Basically, in setup.cfg, there is an alias for pytest which adopts -n 8 --junitxml=pytest.xml. But pytest doesn't take an argument -n, so it fails. When I run the test suite locally, I remove setup.cfg to avoid the alias and just run pytest ./tests. Can you explain a bit what setup.cfg is for? Am I running the test suite correctly?