LLNL / Silo

Mesh and Field I/O Library and Scientific Database
https://silo.llnl.gov
Other
30 stars 24 forks source link

Include only zfp files when needed, re-ran automake #263

Closed brtnfld closed 1 year ago

brtnfld commented 2 years ago

Fixed with zfp is disabled, Silo trying to pull in zfp files in Makefile.am.

Ran automake to update Makefile.in.

markcmiller86 commented 2 years ago

@brtnfld I am happy to merge but I have another, related question.

I am thinking we should pitch Autotools support now that we have decent CMake support.

Thoughts?

brtnfld commented 2 years ago

I only use Autotools as a matter of convenience, but I don't have an issue with switching over to CMake. It would simplify maintenance of not supporting two build systems.

I think spack is using autotools for building silo, so the spack recipe would need to be updated if you decide to remove autotools builds.