Fixes poorly designed freeing of file scope gloabls. Thanks to Dave Bremer.
While doing some testing, I found a memory error in DBClose(). I made a patch and wanted to offer it for inclusion in the Silo source. It's a two-line change, so I could hand it to you directly, or submit it through GitHub.
The dbfile->pub.close() function tends to call free on dbfile, so the pointer at dbfile->pub.file_scope_globals is in freed memory. It tends to work, unless you use a Windows debug build, or if you set MALLOCPERTURB on Linux, which writes a value into a freed buffe
Resolves #221
Fixes poorly designed freeing of file scope gloabls. Thanks to Dave Bremer.
While doing some testing, I found a memory error in DBClose(). I made a patch and wanted to offer it for inclusion in the Silo source. It's a two-line change, so I could hand it to you directly, or submit it through GitHub.
Current code:
Proposed change:
The dbfile->pub.close() function tends to call free on dbfile, so the pointer at dbfile->pub.file_scope_globals is in freed memory. It tends to work, unless you use a Windows debug build, or if you set MALLOCPERTURB on Linux, which writes a value into a freed buffe