search

LLNL / Silo

Mesh and Field I/O Library and Scientific Database
https://silo.llnl.gov
Other
25 stars 22 forks source link

Msvc detection #359

Closed mathstuf closed 8 months ago

mathstuf commented 10 months ago

A variety of fixes that separates the "Windows is Visual Studio" assumptions, fix a few other technicalities I encountered along the way, and some simplifications.

The _MSC_VER patch has a trivial contextual conflict with 4.11RC, but the rest may be helpful there if wanted.

markcmiller86 commented 9 months ago

@biagas this is NOT urgent but if you find some time to have a look at this in the next few weeks, that would be great.

biagas commented 8 months ago

@markcmiller86 I am trying to build this PR on my windows machine to verify a couple of things. using MSVC 2017 silo_ns.c includes regex.h which isn't available, I don't know if this is a new addition since I last built Silo. Not sure of a good replacement, VisIt recently switched to std::regex from using a win32 specific version in our repo.

biagas commented 8 months ago

@markcmiller86 I am trying to build this PR on my windows machine to verify a couple of things. using MSVC 2017 silo_ns.c includes regex.h which isn't available, I don't know if this is a new addition since I last built Silo. Not sure of a good replacement, VisIt recently switched to std::regex from using a win32 specific version in our repo.

Apologies, this is a separate issue from this PR and I will open a new ticket.

markcmiller86 commented 8 months ago

Thanks @biagas for the review