search

LLNL / libROM

Model reduction library with an emphasis on large scale parallelism and linear subspace methods
https://www.librom.net
Other
197 stars 36 forks source link

Fix space-time sampling #290

Closed dylan-copeland closed 2 weeks ago

dylan-copeland commented 2 weeks ago

PR 274 made the temporal basis non-distributed. This PR fixes a check so that space-time ROM works in Laghos.

chldkdtn commented 2 weeks ago

Why does "docs/readthedocs.org:librom" test fail?

dylan-copeland commented 2 weeks ago

readthedocs has the following error, which I don't understand. It is referring to the latest commit in this PR. @ckendrick do you have any ideas?

git checkout --force e899ef1fed32f18d32986b01ac26ed7f1457ebe8 fatal: reference is not a tree: e899ef1fed32f18d32986b01ac26ed7f1457ebe8

ckendrick commented 2 weeks ago

@dylan-copeland I'm not sure why the docs build failed here. The log seems to show it was able to clone the repo and fetch the branch correctly.

Maybe try pushing an empty commit or merging/rebasing this branch on master to kick off the build again and we can see if it still fails or not.

dylan-copeland commented 2 weeks ago

Thanks @ckendrick, the tests passed after pulling from the master branch. I thought the branch was up-to-date, but it wasn't.