LMHT / LMHT.github.io

https://lmht.github.io
15 stars 8 forks source link

move placeholder code into combobox.js only #99

Closed ericanaughton closed 8 years ago

ericanaughton commented 8 years ago

In order to prevent confusion for other contributors, As a contributor to LMHT, I want to move the 'input' code from script.js into combobox.js, so that code will target only the combobox, rather than the javacript in the whole site.

Acceptance Criteria:

Given a contributor to LMHT, When I look at the code in combobox.js, I will see that the 'input' code is properly placed there, And 'Search/Buscar' is displayed when an element is not chosen.

ericanaughton commented 8 years ago

note: line 11 in combobox.js was followed by this comment...

     // clear the default selected option so that we see the placeholder text
    //  this.input.value = '';
    //  console.log(this.input)
ericanaughton commented 8 years ago

PR adorableio/LMHT#27 ready for review

ericanaughton commented 8 years ago

merged to adorable master