LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.19k stars 1.01k forks source link

Envelope pitch feature #1466

Open mikobuntu opened 9 years ago

mikobuntu commented 9 years ago

Demo of Pitch Envelope in FL

Pitch Envelope thoughts

edit ... my git formatting sucks

Sti2nd commented 9 years ago

A pitch envelope is basically en envelope which does portamento to a certain pitch at a certain time in the note length?

Should one have multiple knobs for that? This looks very much like the Kicker knobs...

mikobuntu commented 9 years ago

A pitch envelope is basically en envelope which does portamento to a certain pitch at a certain time in the note length?

Yes all except we may ( in certain cases as in the video example ) want the pitch to slide back to it's original starting position, but this could maybe still be possible using your knobs idea. 1 downside is that some instruments e.g Triple_oscillator do not have much space left for realising these knobs tho, whereas there is space for allowing this feature in the ENV tabs :) ( and this will be global for all internal instruments).

tresf commented 9 years ago

Yeah, your original description could use some reformatting. :)

diizy commented 9 years ago

On 12/19/2014 01:30 PM, Mikobuntu wrote:

Demo of Pitch Envelope in FL http://youtu.be/cyuVEK--pPo?t=4m45s

Pitch Envelope thoughts:-

|* Although we already can control pitch within an instrument, It has to be automated to achieve what a pitch envelope can achieve.

  • Pitch Envelope will allow for creating more complex instruments ( for sharing ).
  • This will work using the same ADSR settings available already in the ENV section of Plugins. |

No, it won't.

The fundamental problem here is that pitch is a note property. It needs to be known before rendering the note. Envelopes, on the other hand, are applied on the note after it is rendered. You see the problem here?

The way envelopes work in LMMS, there is just no good way to apply them to pitch. If there's to be any kind of pitch envelope, it needs a whole separate mechanism.

mikobuntu commented 9 years ago

@diizy yes I now understand the concept of pitch being a note property :) And i can see how this will be problematic to implement without creating a whole new mechanism.

I don't want to confuse my original thoughts ( or anyone else's ) on this post, but another possible avenue to investigate could be to allow manual drawing of a " Pitch Envelope" somewhere within the GUI of the Plugins. It could work in a way such as our 2 plugins i.e Dynamics Processor and Waveshaper effect allow freehand and shift click ( straight line drawing )...... which leads me to think that it "could???" be possible to implement this as an actual 'pitch changing' native LMMS effect. Think of the graph as our automation, which can be added to any instrument which makes sharing a dodle, and it will effect the Pitch mechanism already in place on all plugins.

mikobuntu commented 9 years ago

@tresf good job on fixing my terrible git formatting, I will make a point of learning how to present my issues a lot neater from now on ;)

diizy commented 9 years ago

On 12/19/2014 04:12 PM, Mikobuntu wrote:

which leads me to think that it "could???" be possible to implement this as an actual 'pitch changing' native LMMS effect.

It's still the same problem. Effects are processed after the note has been rendered. Pitch needs to be known before.

mikobuntu commented 9 years ago

@diizy yeah I see now thanks :)

tresf commented 9 years ago

Effects are processed after the note has been rendered. Pitch needs to be known before.

Not to sound too nosy here, but how the heck do live pitch bends work then?

-Tres

diizy commented 9 years ago

On 12/19/2014 09:23 PM, Tres Finocchiaro wrote:

Effects are processed after the note has been rendered. Pitch
needs to be known before.

Not to sound too nosy here, but how the heck do live pitch bends work then?

They're automation patterns attached to notes, that get processed on the fly before the note is rendered.

Sti2nd commented 9 years ago

But that is exactly what mikobuntu suggested with the drawing? I understand that it isn't just to add some code to the existing envelope code.

diizy commented 9 years ago

What drawing

tresf commented 9 years ago

@mikobuntu your video link is broken, please remove it or fix it. :+1:

Qtamo commented 2 years ago

I think this is still the one type of major envelope that LMMS native instruments are missing. Would be great to see it added IMO!