Increase GUI contrast in active/inactive buttons

[anytizer]

The active and inactive buttons feel like very similar, causing difficulties in identifying which one is active. It would be nice to have a bit more contrast in those buttons' background color.

In the picture, "No" is selected, but it is visually weaker to know. Pressing SPACE BAR would send ENTER to "No" button.

Obtaining the above dialog/prompt: LMMS > Ctrl + O > Try to delete an LMMS File.

[musikBear]

Not but, but enhancement, and one important one. There are select-color mistakes in lmms. One of the more strange is that we use black as text-select color -Everywhere If the green frame diddent gave it away, would you spot witch name was selected? Meta-wise this goes under accessibility

[anytizer]

Slightly difficult to determine which tab is currently active.

[anytizer]

Also, #6730

[michaelgregorius]

The first issue could be fixed by extending the style sheet with a definition for QPushButton::default, e.g.:

QPushButton::default {
    background-color: #6c757f;
}

This would make the dialogues look as follows:

The gray might be a bit too light though because it makes the text less readable.

[michaelgregorius]

The second issue about the selection color of the line edit has been fixed with commit 69a35b58 in pull request #5687. Currently it looks as follows:

[musikBear]

In this case i still have issue seeing the focused button. I would prefer more 'bling' to make it blatantly obvious, like

Ugly mockup, but i believe its clear.

[michaelgregorius]

Here's how it looks if the default button has a green text color.

With the delete dialog I think there's too much green in the icons and text so that it becomes rather confusing:

On the file selection dialog it's too subtle and the default "OK" button look less important than the "Cancel" button:

Although one of the problems is that the icon that's used for "No" and "Cancel" should not be green but red instead.

[musikBear]

On the file selection dialog it's too subtle and the default "OK" button look less important than the "Cancel" button:

That is correct

"Cancel" should not be green but red instead.

Also agree Perhaps we could do something with green complementary colour -Orange, so we get something like:

It stands out, but is also ugly. Rebekka would have to chime in Another option could be a new design of the button so the one in focus has a green outline like: But that is a question if qT support that

[flurick]

QPushButton:focus {
  border: 1px solid lightgreen;
  border-radius: 4px;
  background-color: #17793b;
}

[Rossmaxx]

@flurick if you don't mind, can you open a PR?

[musikBear]

...

I like the border ! It shows what button is in focus, bur perhaps 2 px outline would be clearer. The green button-color is however confusing. Many would exspect that green would be for a save-button. In this case the green button would not save anything, but just close, that is not intuitive.

[Rossmaxx]

Since flurick has not responded, i decided to take up this one #7202.

[RoxasKH]

Leaving here a couple of info/mockups about the issue that i've talked about in #7202

here's a couple of quickly drafted option that take inspiration from other programs, one just changes the selectede button color, the other uses an outer border to give a dvisual difference both in colors and perceived size

Colored	Border

In the border one, bg color might also gets a little darker, but it should keep the gradient and shouldn't reach the point where it blends in to the background.

Ps side note: the colored button proposal was also mentioned about making the loop state more evident in https://github.com/LMMS/lmms/issues/3069 , where Rebecca also proposed a darker background/green icon mock-up that could also apply as a possible option here too.