search

LOLINTERNETZ / vscodeoffline

Enables Visual Studio Code's extension gallery to be used in offline (air-gapped) environments. Or, run your own gallery!
https://hub.docker.com/u/lolinternet
MIT License
101 stars 31 forks source link

Correctly handle and download extensions with multiple versions #21

Closed forky2 closed 2 years ago

forky2 commented 3 years ago

Fix #19 by correctly downloading multiple versions of extensions when they present.

jellard1 commented 2 years ago

@LOLINTERNETZ Can you approve this merge? I verified this fixed the issue I was having with multiple versions (specific to ms-vscode.cpptools extension). vscsync_1 | [W 220208 17:35:50 sync:204] _get_asset_types(). More than one version returned for ms-vscode.cpptools. Unhandled. vscsync_1 | [W 220208 17:35:50 sync:178] version(). More than one version returned for ms-vscode.cpptools. Unhandled. vscsync_1 | Traceback (most recent call last): vscsync_1 | File "/opt/vscoffline/sync.py", line 590, in <module> vscsync_1 | bonus = extensions[identity].process_embedded_extensions(config.artifactdir_extensions, mp) + bonus vscsync_1 | File "/opt/vscoffline/sync.py", line 156, in process_embedded_extensions vscsync_1 | manifestpath = os.path.join(destination, self.identity, self.version(), 'Microsoft.VisualStudio.Code.Manifest')

Thanks @forky2! It would be great to get the image updated, https://hub.docker.com/r/lolinternet/vscsync.

LOLINTERNETZ commented 2 years ago

Thanks @forky2 and @jellard1. Not sure how I missed this PR