Multi-platform extensions not supported

LOLINTERNETZ / vscodeoffline

Enables Visual Studio Code's extension gallery to be used in offline (air-gapped) environments. Or, run your own gallery!

https://hub.docker.com/u/lolinternet

MIT License

101 stars 31 forks source link

Multi-platform extensions not supported #24

Closed k-jingyang closed 2 years ago

k-jingyang commented 2 years ago

Hey, thanks for making this :smiley:

I realised that the current implementation doesn't seem to support extensions that differ across platforms. One such example would be redhat.java

POST https://marketplace.visualstudio.com/_apis/public/gallery/extensionquery returns something like this for redhat.java

Ebsan commented 2 years ago

I think I've got a fix for this in my pull request (#36). I've also updated the vscgallery code to serve up the the correct targetPlatform as well. @k-jingyang you're more than welcome to test and let me know how it works for you.

LOLINTERNETZ commented 2 years ago

Should be fixed in the just released 1.0.21. Feel free to re-open if needed.