search

LPCIC / coq-elpi

Coq plugin embedding elpi
GNU Lesser General Public License v2.1
134 stars 50 forks source link

Please pick the version you prefer for Coq 8.18 in Coq Platform 2023.10 #511

Open rtetley opened 11 months ago

rtetley commented 11 months ago

The Coq team released Coq 8.18.0 on September 7th, 2023. The corresponding Coq Platform release 2023.10 should be released before November 30th, 2023. It can be delayed in case of difficulties until January 15th, 2023, but this should be an exception.

This issue is to inform you that the opam package we are currently testing in Coq Platform CI works fine with Coq 8.18.0.

Coq Platform CI is currently testing opam package coq-elpi.1.19.0 from official repository https://coq.inria.fr/opam/released/packages/coq-elpi/coq-elpi.1.19.0/opam.

In case this is the version you want to see in Coq Platform, there is nothing to do for you - please just close this issue.

In case you would prefer to see an updated or an older version in the upcoming Coq Platform 2023.10, please inform us as soon as possible and before October 31st, 2023!

The working branch of Coq Platform, can be found here main. It contains package pick ~8.18+beta1 which already supports Coq version 8.18.0 and contains already working (possibly patched / commit pinned) Coq Platform packages.

In case you want to select a different version, please don't close this issue, even after creating the new tag and/or opam package. We will close the issue after updating Coq Platform. This is a measure of 'double book keeping' in order to avoid that we ship the wrong version.

In any case, Coq Platform won't be released before this issue is closed!

Thanks!

P.S.: this issue has been created automatically based on CI status.

CC: https://github.com/coq/platform/issues/372

gares commented 11 months ago

Versions before 1.19.3 are broken in VsCoq2, please pick >= 1.19.3

rtetley commented 10 months ago

I will update the platform to contain coq-elpi.1.19.3, however you closed the issue for elpi which contains version 1.17.3 in the platform, should I leave that or update it to the latest version (1.17.4) ? just double checking !

rtetley commented 10 months ago

@gares, doing a round of reminder. Currently the plan is to include 1.19.3 and 1.17.4 in the platform. But I believe you would like us to wait for a new release ?

gares commented 10 months ago

If possible yes. Elpi 1.18.0 is out in OPAM (but not marked as compatible with Coq-Elpi). I hope to finish a release of Coq-Elpi soon (using elpi 1.18.0 and fixing the problems it had with vscoq2). Then also HB needs a little update.

So, don't hold your breath. I'll do my best, but I understand if you can't wait for me.

MSoegtropIMC commented 10 months ago

@gares : we are closing the pick very soon - so it is now or next release.

As far as I can see the latest coq-elpi version is still 1.19.3, which required elpi < 1.18

gares commented 10 months ago

I'm sorry, I'm not finished yet with the next release, I need two more weeks (at least). Please go on with 1.19.x.

I believe the constraint to elpi < 1.18 can be relaxed, IIRC that release, in the end, does not break the API (but will emit some warnings at compile time).

MSoegtropIMC commented 10 months ago

To be explicit, you recommend to use:

gares commented 10 months ago

In order to minimize your work, elpi 1.17.4 is just fine, and you don't need to patch the coq-elpi opam package. (if for any other reason you need elpi 1.18.0, then it will just work, modulo the opam patch)