search

LPGhatguy / aftman

Aftman, the prodigal sequel to Foreman
MIT License
157 stars 16 forks source link

Fix clippy lints #24

Closed Yumacide closed 2 years ago

Yumacide commented 2 years ago

Seems like clippy's in the CI but you didn't pass -D warnings. Is this intentional?

LPGhatguy commented 2 years ago

Seems like clippy's in the CI but you didn't pass -D warnings. Is this intentional?

There are some things that clippy will deny by default. I think that using -D warnings is usually a mistake because it can cause new PRs to fail CI even though it isn't their fault, from a new clippy version.

Yumacide commented 2 years ago

Whoops.

LPGhatguy commented 2 years ago

Oh, deleting branches once they're merged is totally fine. GitHub recommends this usually and has settings to do it for you.