Issue#52/fix snid problem

LSSTDESC / Monitor

Extract light curves for time-variable cosmological objects

BSD 3-Clause "New" or "Revised" License

3 stars 1 forks source link

Issue#52/fix snid problem #53

Closed rbiswas4 closed 7 years ago

rbiswas4 commented 8 years ago

Changed import of DBObject in dbConnection to reflect changes to catsim architecture
Changed snid to id in truth.py to reflect changes to catsim database table variable names
Changed snid to id and fixed DBObject import in example notebook.

Notebook works on my computer.

Fixes #52

jchiang87 commented 8 years ago

@rbiswas4 These changes look fine, but they are breaking in travis since the distribution of lsst-sims we are getting from http://conda.lsst.codes/sims doesn't seem to have the lsst.sims.catalogs.db module yet. Is that available from a conda dist? @danielsf Have we settled on a sims build to use? (https://github.com/DarkEnergyScienceCollaboration/Twinkles/issues/306) We'll also need to install that at SLAC and NERSC to make progress on Run3.

rbiswas4 commented 8 years ago

Right, the thing is that catsim has changed so that lsst.sims.catalogs.generation is now lsst.sims.catalogs. But it seems that this is not reflected in the conda version yet. I was going to check with @danielsf if this is really the case.

The unfortunate problem is this might be hard to handle with something like a skip test condition

danielsf commented 8 years ago

Sorry. Still no conda build of sims 2.3.0. I will ping the appropriate players.

jchiang87 commented 7 years ago

I've got things set up in the SLAC Jenkins server to build against our installation of sims 2.3.1. Unless I hear some objections before 4pm PT, I'll merge this into master so that we can run in Jenkins. (I still need to figure out how to get it to trigger on PRs, etc.).

jchiang87 commented 7 years ago

BTW, the Jenkins builds are here