The RESSPECT project is a result from an inter-collaboration agreement established between the Cosmostatistics Initiative (COIN) and the LSST Dark Energy Science Collaboration (DESC) with the goal of developing a recommendation system for telescope resource allocation able to optimize photometric supernova cosmology anaylsis.
MIT License
1
stars
0
forks
source link
Incorrect use of kwargs vs self.kwargs and load_classifier #68
In some ResspectClassifier subclasses, we expect there to be specific kwargs provided. We use get to pull the expected keys from the kwarg dict, but then pass the **kwarg to the classifier definition as well.
This results in parameters being passed twice.
Additionally, the method to load a pretrained classifier is called load_classifier, but in database.py it is referred to as load. So we need to update the name there.
In some ResspectClassifier subclasses, we expect there to be specific kwargs provided. We use
getto pull the expected keys from the kwarg dict, but then pass the **kwarg to the classifier definition as well.This results in parameters being passed twice.
Additionally, the method to load a pretrained classifier is called
load_classifier, but indatabase.pyit is referred to asload. So we need to update the name there.