search

LSSTDESC / gcr-catalogs

A Python module that provides a unified interface to access mock galaxy catalogs and more for the LSST DESC
https://github.com/LSSTDESC/gcr-catalogs
BSD 3-Clause "New" or "Revised" License
26 stars 20 forks source link

Bump version to v1.5.0 #620

Closed yymao closed 1 year ago

yymao commented 1 year ago

We have enough updates and also some new catalogs that we should make a new release. Note that #607 is not entirely backward compatible, and we should write a warning sentence in the release note and probably on the data portal as well.

@evevkovacs or @JoanneBogart, would you be able to help write that warning sentence?

evevkovacs commented 1 year ago

Draft warning sentences: Note that the default values for position_angle have changed from this version going forward. The values of position_angle are now derived from the native quantity 'morphology/positionAngle', rather than random values generated by the GCR reader that were used for DC2. The former values are still available as 'position_angle_true_dc2'. Furthermore, the sign convention for position_angle has flipped and now increases to the East. The previous versions used the phosim convention (increasing to the West). The phosim convention values are available as 'position_angle_true_phosim'. Note also that, because position_angle is used in the definition of the ellipticity components, these quantities have also changed. The quantities ellipticity_1_true_dc2 and ellipticity_2_true_dc2 supply the legacy values used for DC2.

evevkovacs commented 1 year ago

Please feel free to edit the above sentences.

JoanneBogart commented 1 year ago

LGTM! Thanks @evevkovacs

yymao commented 1 year ago

Thanks @evevkovacs. @JoanneBogart can you give this PR a quick approval?