LSSTDESC / imSim

GalSim based Rubin Observatory image simulation package
https://lsstdesc.org/imSim
BSD 3-Clause "New" or "Revised" License
36 stars 15 forks source link

CI skyCatalogs install fix + doc fixes #476

Closed esheldon closed 3 months ago

esheldon commented 3 months ago
esheldon commented 3 months ago

the CI failure here is the same failure fixed by the indication in the docs.

I'll push a change to the CI fixing this

esheldon commented 3 months ago

I checked and today this also fails for my other repo. What worked yesterday does not work today, maybe due to a change in the setuptools used in CI

esheldon commented 3 months ago

With help from @beckermr it seems this is due to another change showing up today, setuptools moving to version 70.

esheldon commented 3 months ago

Bug found, in pyproject.yaml the line should be changed

version = {attr = ".skycatalogs._version.__version__"}
to
version = {attr = "skycatalogs._version.__version__"}

There is an extra "."

esheldon commented 3 months ago

https://github.com/LSSTDESC/skyCatalogs/pull/102

jchiang87 commented 3 months ago

I'd like to go ahead and merge this tomorrow morning ~8am PT unless someone objects.