Open hangqianjun opened 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.38%. Comparing base (
30a570f
) to head (ee912d9
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Some notes with the PR (and my confusions):
check_columns
functions (they are all called similar names) defined in tables_io
as well as inrail.core.data
and rail.core.stages
all have **kwargs
which are unspecified parameters needed when reading in the files, dependent on the file type. These parameters for now are not included, registered, or propagated through RAIL when running interactively or from a ceci pipeline. So, when these check_columns
functions are called in a specific stage (informer & estimator), the **kwargs
are omitted. This should be considered later on._check_column_names()
function in rail.core.stages
allows the input data to be a) a datahandle with just path, b) a datahandle with data, and c) an actual table of data. When running interactive mode, all stages will call set_data(), which will always give case b). I'm not sure when will cases a) and c) be required, perhaps when running in pipeline mode?check_columns
for TableHandle
, but not for qp files yet. Would be great if someone can give some suggestions on whether this is needed for qp files.validate()
function doens't exist in the ceci public release yet, so the dependence is changed to the ceci main branch in order to have the tests pass. We can wait until ceci has made a release to merge this.
Problem & Solution Description (including issue #)
This PR addresses #120 and implement the check_columns function in tables_io into the rail base classes.
Code Quality
#pragma: no cover
; in the case of a bugfix, a new test that breaks as a result of the bug has been added