search

LSSTDESC / snmachine

Machine learning code for photometric supernova classification
BSD 3-Clause "New" or "Revised" License
9 stars 5 forks source link

make utils package a subpackage #258

Closed heather999 closed 2 years ago

heather999 commented 2 years ago

As discussed on desc-help, we are going to make utils a subpackage and update the pypi installation appropriately.

heather999 commented 2 years ago

Dear @Catarina-Alves I'm sorry for the long delay - I have started to look at this again and will try to get back to you early next week!

Catarina-Alves commented 2 years ago

Hi @heather999, have you had some time to look at this? Thank you

heather999 commented 2 years ago

Looking at it now! I find part of the issue is that there is old code under snmachine/utils/archive which I believe is no longer relevant. I am moving that archive directory aside and placing it back at the top-level of this repo.. then I am able to do a editable pip install using this copy of the code and run some of the example notebooks... with some minor modification now that utils is a subpackage of snmachine. So I am modifying things to look like: from snmachine.utils.plasticc_pipeline import get_directories, load_dataset I recall you didn't need to do that when you tested against the original PR, but I still think that is necessary. I'll update the PR and we can both test this out again (and hopefully finally close this!)

Catarina-Alves commented 2 years ago

Solved by #259