LSSTDESC / start_paper

Make a folder containing everything you need to start writing an LSST DESC paper or Note
BSD 3-Clause "New" or "Revised" License
11 stars 4 forks source link

Spaces in short_title #54

Closed kadrlica closed 7 years ago

kadrlica commented 7 years ago

The short_title gets parsed into the default folder name (which is nasty enough to have a space in it), but then the Makefile sets the outname based on the dirname. This causes problems in make copy because we don't have quotes around the filenames. There are two solutions:

  1. Use quotes in copy here. Specifically, cp "${main}.pdf" "${outname}.pdf"
  2. Replace spaces with underscores when parsing the directory name.

I prefer the second solution, but it requires a change to the cookiecutter template, which would take me more than 30 seconds to figure out. @drphilmarshall - is this easy for you?

kadrlica commented 7 years ago

As a follow up, do we really want the repo name and short title in the folder name?

"folder_name": "desc-{{ cookiecutter.serial_number }}-{{ cookiecutter.repo_name.lower() }}-{{ cookiecutter.short_title.lower() }}"
kadrlica commented 7 years ago

I think this is obsolete with the removal of cookiecutter; cleaning up following #65.