Upgrading BrighterFatter to v18.1.0 - Githubissues

LSSTScienceCollaborations / StackClub

Learning the LSST software Stack, by writing jupyter notebook tutorials.

https://stackclub.readthedocs.io/

MIT License

45 stars 17 forks source link

Upgrading BrighterFatter to v18.1.0 #214

Closed kadrlica closed 5 years ago

kadrlica commented 5 years ago

@andrewkbradshaw here is my start on the upgrade.

I've implemented several places where you'd commented that API changes were necessary
I've change one of the source table field names

Some issues:

The Firefly window is opening in a separate tab (not sure if this was supposed to open a frame in the notebook)
It appears that the isrTask doesn't have a brighterFatterCorrection anymore (not sure if this is just a renaming or something more fundamental).