search

Ladicle / flymake-posframe

Showing flymake diagnostics at point using posframe
GNU General Public License v3.0
32 stars 8 forks source link

don't work on 28.2 #3

Open 11111000000 opened 2 years ago

11111000000 commented 2 years ago

error

Error in post-command-hook (flymake-posframe-display): (wrong-type-argument stringp nil)

articuluxe commented 2 years ago

I assume you are using eglot?

This code: :string (concat (propertize (pcase (flymake--diag-type diag) (:error flymake-posframe-error-prefix) (:warning flymake-posframe-warning-prefix) (:note flymake-posframe-note-prefix)) 'face 'warning) (flymake--diag-text diag)))

needs to add handlers for 'eglot-error', 'eglot-warning' and 'eglot-note'. Currently the prefix does not match the eglot-specific flymake errors, and errors out.

Is this repo still alive? Would an MR be accepted?

articuluxe commented 2 years ago

Well, I've created an MR, hope it can be merged: https://github.com/Ladicle/flymake-posframe/pull/4

garyo commented 1 year ago

I'm getting the same error, for the same reason -- using eglot. Would like to see this merged.