search

LadybirdBrowser / ancient-history

The Ladybird web browser
BSD 2-Clause "Simplified" License
1.62k stars 107 forks source link

Misc: Add ladybird.nix for nix support #72

Closed Baitinq closed 1 year ago

Baitinq commented 1 year ago

This adds nix/nixos building support like the Toolchain/serenity.nix in serenity.

Let me know if this needs any changes/is not needed :^))

ADKaster commented 1 year ago

I'm not super familiar with the nix ecosystem, how does this local file interact with the upstream nixpkg here? (which has an open PR for updates)

https://github.com/nixos/nixpkgs/blob/master/pkgs/applications/networking/browsers/ladybird/default.nix

Baitinq commented 1 year ago

I'm not super familiar with the nix ecosystem, how does this local file interact with the upstream nixpkg here? (which has an open PR for updates)

https://github.com/nixos/nixpkgs/blob/master/pkgs/applications/networking/browsers/ladybird/default.nix

This local file would be a development only environment (sets up an environment with all the dependencies needed to build ladybird), whereas the nixpkgs derivation provides an "already built" ladybird, as the derivation automatically builds it.

Im not sure if I've made myself clear haha, lmk if a better explanation is needed

Baitinq commented 1 year ago

Rebased against master. Is this pr of interest or is this not needed? @awesomekling