search

LadybirdBrowser / ladybird

Truly independent web browser
https://ladybird.org
BSD 2-Clause "Simplified" License
22.43k stars 1k forks source link

LibWeb: Fix FileAPI constructor #2517

Open shlyakpavel opened 6 days ago

shlyakpavel commented 6 days ago

This fixes http://wpt.live/FileAPI/file/File-constructor.any.html

stelar7 commented 5 days ago

Please make sure this doesnt cause any new fails on https://wpt.live/mimesniff/mime-types/parsing.any.html as this code was originally changed to pass tests there😅

shlyakpavel commented 5 days ago

@stelar7 should I import that WPT with this PR?

stelar7 commented 5 days ago

@stelar7 should I import that WPT with this PR?

We dont pass everything there, so im not sure its possible.. but it should atleast still be 1894 / 1898 tests passing

shlyakpavel commented 5 days ago

@stelar7 there are regressions :(

tcl3 commented 5 days ago

@stellar7 Do you know if there's an existing issue for this that we can reference in the code?

stelar7 commented 5 days ago

@Stelar7 Do you know if there's an existing issue for this that we can reference in the code?

This is probably the closest one https://github.com/w3c/FileAPI/issues/43