LagoLunatic / DSVEdit

Multi-purpose editor for ROM hacking DS and GBA Castlevania games
MIT License
92 stars 13 forks source link

HoD Issues #58

Closed Casterol closed 3 years ago

Casterol commented 3 years ago

(on Windows 10) In the warp room (084AA53C) with the cutscene of Death going into the warp, deleting and re-adding this event entity messes up the door palette during the cutscene. There's a typo in the description for the special object, "Giant hammer that hits Bronze Guarder back" that says "detroyed". Excessive use (loading every room, right-clicking & changing/deleting every entity) will eventually crash the editor with no error message. Changing the Var A of events to high values (3A/3B/etc.) results in this: image

LagoLunatic commented 3 years ago

In the warp room (084AA53C) with the cutscene of Death going into the warp, deleting and re-adding this event entity messes up the door palette during the cutscene.

Hmm. It's not related to editing the event. When you save a room at all, DSVEdit removes entity palette entries from that room's palette list so the entities automatically load their own palettes instead, which usually works fine and simplifies things. But it seems that Death and a warp point being in the same room causes it to load both of their palettes to the same slot if leaving it to the automation. For now I created #59 for this bug.

Excessive use (loading every room, right-clicking & changing/deleting every entity) will eventually crash the editor with no error message.

That's a memory leak that I'm pretty sure I can't fix. It's always happened in DSVEdit, for all games, regardless of what you do. Probably a bug in qtbindings. I recommend saving your work frequently.

There's a typo in the description for the special object, "Giant hammer that hits Bronze Guarder back" that says "detroyed". Changing the Var A of events to high values (3A/3B/etc.) results in this:

Fixed