search

LagoLunatic / DSVEdit

Multi-purpose editor for ROM hacking DS and GBA Castlevania games
MIT License
92 stars 13 forks source link

Fix bug in por_inter-area_warps.asm #93

Closed Rexius55 closed 1 month ago

Rexius55 commented 1 month ago

Made a couple changes to fix the warp screen breaking when the info screen is present on the subscreen. Bug in question: #92

LagoLunatic commented 1 month ago

Thanks for figuring this bug out!

Regarding this part: "Fixes a bug in the original ASM where the area index for the warp screen would always load as 00" The 00 bug didn't exist in the original code, it was introduced when you added those extra function calls to SetAreaIndexOnWarpScreenOpen, because that clobbers register r0, which is then passed as the argument to a function after returning to the vanilla code.

Fixed the bug with a simpler solution here: b8a3f0015b15ce9338e1d48614659e576172da1d