search

LaihoE / SIMD-itertools

Faster implementations of standard library operations like find, filter, position etc.
168 stars 3 forks source link

Multiversion in lieu of compiling from source with RUSTFLAGS="-C target-cpu=native" #7

Closed smu160 closed 3 months ago

smu160 commented 4 months ago

Hi @LaihoE,

I was wondering if you are open to uitilizing the multiversion crate to utilize dyanamic dispatch, rather than having users compile from source (to get the best performance).

I use multiversion for my own project and it's great! You can see example usage here.

I can run a before/after benchmark using your existing benchmarks to check for any regressions.

Thank you!

LaihoE commented 4 months ago

Yes, multiversion seems like the way to go. Do you want implement it?

smu160 commented 4 months ago

@LaihoE

I'll start on a PR for this issue once the benchmarks PR is sorted out. That way, I can easily establish a baseline to test for regressions. Thank you!!

LaihoE commented 3 months ago

Sorry if you were working on this, It is just blocking some future ideas with SIMD_LEN, so I went ahead and added multiversioning.

smu160 commented 3 months ago

@LaihoE All good! Apologies for the delays.