LanceMcCarthy / MvpApi

An application for Microsoft MVPs to easily browse and upload contributions
MIT License
36 stars 10 forks source link

Contribution Uploads Override Date #152

Closed adamj7 closed 3 years ago

adamj7 commented 3 years ago

The default override date is 2016, and the default submissions deadline override is 2020. It's a pain to keep overriding them because I end up forgetting and losing out all submissions in queue.

Is it possible to dynamically pull dates? eg. If today's date is (CurrentYear,month,day) >= (CurrentYear).04.01 Start: (CurrentYear).04.01 Deadline: (CurrentYear+1).03.31 If today's date is (CurrentYear,month,day) <= (CurrentYear).04.01 Start: (CurrentYear-1).04.01 Deadline: (CurrentYear).03.31

This way, if an override is necessary it's outside of the norm.

LanceMcCarthy commented 3 years ago

Hi Adam,

I'm working on an update now that will bump up the gloabl Submissions Deadline date.

The MVP Companion app used to use a boundary condition to dynamically set the start and end date based on the current award year (similar to how you've proposed). However, this was an issue when MVPs would try to submit seemingly valid contributions, but the API would reject them. This is just a limitation to the API itself and you could go into the MVP portal and enter the activity.

Regarding the date overrides, I thought I had persisted the overrides so that the next time you open the app you don't have to go back into Settings to change it again. I will make sure that it retains whatever you set in there.

LanceMcCarthy commented 3 years ago

Hi Adam, quick update. I've pushed some changes that include persisting any updates you make to the min and max dates for the contribution year. That way, you do not have to keep changing the setting.

I also added some logic that sets the default to the current MVP year. You can still override it, but it does save you some initial headache if I can't get an update out in time for a new MVP year.

adamj7 commented 3 years ago

Sweet - When is it going to be released? I just checked the Microsoft store for updates and there were none for the MVP Companion. I'm at version 1.9.5.

LanceMcCarthy commented 3 years ago

It's going through devops build and testing now. I'll let you know when it is live (the version will now be 2021.x.x when the devops builds are done and pushed to Microsoft).

Lance Sent from Ninehttp://www.9folders.com/


From: Adam Marshall @.***> Sent: Monday, August 30, 2021 8:34 PM To: LanceMcCarthy/MvpApi Cc: Lance McCarthy; Comment Subject: Re: [LanceMcCarthy/MvpApi] Contribution Uploads Override Date (#152)

Sweet - When is it going to be released? I just checked the Microsoft store for updates and there were none for the MVP Companion. I'm at version 1.9.5.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/LanceMcCarthy/MvpApi/issues/152#issuecomment-908804248, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA23QFBNBK2YYZTA4UKPBRTT7QPQRANCNFSM5APUU33Q.

LanceMcCarthy commented 3 years ago

[update] the beta version is live in the Store.

I just pushed a beta release to Microsoft, it can take a few hours to go through. If you'd like to be in the beta group, please DM me on twitter (@lancewmccarthy) with the Microsoft Account email address you use for the Store

LanceMcCarthy commented 3 years ago

I pushed the Beta release to Production. It may take a few days to pass certification because of the long weekend. You can check for updates through the Store app to force it to update faster (the new version is 2021.8.31).

Once you get the update, go to the Settings page to see the new auto-configured dates. If you do need to change them in the future, those new values get stored locally so you don't need to do it again.

[UPDATE] Certification was fast, the updating is publishing image

[UPDATE 2] Available now, go to https://www.microsoft.com/store/productId/9NRXNX3WLH77 or manually check for updates.

LanceMcCarthy commented 3 years ago

Confirmed working after update, closing issue. Overrides are auto-calculated for the current year and any custom overrides are persisted.