search

LanceMcCarthy / MvpApi

An application for Microsoft MVPs to easily browse and upload contributions
MIT License
36 stars 10 forks source link

Not pulling existing items through #43

Closed JasonWynn closed 5 years ago

JasonWynn commented 6 years ago

Hello, I can see that the Home Page displays my items submitted but doesn't show line to by line items within the actual displays. I can refresh and try to filter but nothing seems to show, however in the upper right-hand corner I can see that the items are being pulled. In addition, I can submit items fine.

LanceMcCarthy commented 6 years ago

Hi Jason!

I'm not sure exactly what you mean by "doesn't show line to by line items within the actual displays"

What happens if you set the BatchSize to 25 instead of the default 50 (find this setting under the wrench icon in the appbar)

JasonWynn commented 6 years ago

I’ve shut down while its Story time for the little people, but I’ll try to get a screen grab for you in a minute.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Lance McCarthy notifications@github.com Sent: Wednesday, March 28, 2018 4:57:14 PM To: LanceMcCarthy/MvpApi Cc: Jason Wynn; Author Subject: Re: [LanceMcCarthy/MvpApi] Not pulling existing items through (#43)

Hi Jason!

I'm not sure exactly what you mean by "doesn't show line to by line items within the actual displays"

What happens if you set the BatchSize to 25 instead of the default 50 (find this setting under the wrench icon in the appbar)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/LanceMcCarthy/MvpApi/issues/43#issuecomment-376939326, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AkHsxW3ooCJUYf0jwR6f4dfEs4XW5nVOks5ti7LagaJpZM4S-0lq.

JasonWynn commented 6 years ago

Works perfectly on 25 rather than 50, thank you.

Odd how that works, should it do that? Or should it display on 50+?

From: Lance McCarthy notifications@github.com Sent: 28 March 2018 16:57 To: LanceMcCarthy/MvpApi MvpApi@noreply.github.com Cc: Jason Wynn JASON.WYNN@WYNNWARE.COM; Author author@noreply.github.com Subject: Re: [LanceMcCarthy/MvpApi] Not pulling existing items through (#43)

Hi Jason!

I'm not sure exactly what you mean by "doesn't show line to by line items within the actual displays"

What happens if you set the BatchSize to 25 instead of the default 50 (find this setting under the wrench icon in the appbar)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/LanceMcCarthy/MvpApi/issues/43#issuecomment-376939326, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AkHsxW3ooCJUYf0jwR6f4dfEs4XW5nVOks5ti7LagaJpZM4S-0lq.

LanceMcCarthy commented 6 years ago

I'm tracking an issue where if the batch number is lower than your total number of contributions, it's not parsing the result correctly.

The same also happens if you have a large amount (say 285) and you get to the last set of items that is lower than the batch number (items 275-285), they don't appear either.

I'll be working on that as soon as I finish a higher priority bug (some profile photos are not decoding from Base64 correctly)

Reference note: Related to https://github.com/LanceMcCarthy/MvpApi/issues/28

LanceMcCarthy commented 5 years ago

Circling back to this after discovering an issue with the API, it's not loading any contributions older than 2016. This causes a bad problem with paging if you have been an MVP for longer than a couple years because the TotalContributions number the API returns is never the total number of items it returns.

The only solution I have at this point is to fetch everything, and rely on UI Virtualization for smooth operation. This will solve everyone's problem, but will take a couple seconds longer to load the DataGrid.

This will be in the 1.8.2 update coming today or tomorrow.

JasonWynn commented 5 years ago

Lance, you do realise you’re allowed to have time off mate? 😊

On 26 Dec 2018, at 17:06, Lance McCarthy notifications@github.com<mailto:notifications@github.com> wrote:

Circling back to this after discovering an issue with the API, it's not loading any contributions older than 2016. This causes a bad problem with paging if you have been an MVP for longer than a couple years because the TotalContributions number the API returns is never the total number of items it returns.

The only solution I have at this point is to fetch everything, and rely on UI Virtualization for smooth operation. This will solve everyone's problem, but will take a couple seconds longer to load the DataGrid.

This will be in the 1.8.2 update coming today or tomorrow.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/LanceMcCarthy/MvpApi/issues/43#issuecomment-449994731, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AkHsxTwq2E15tvCHC7qUD17lzd2cut3hks5u86yhgaJpZM4S-0lq.