Incorrect elements for numerous status effects

[ShiyoKozuki]

• [x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
• [x] I have searched existing issues to see if the issue has already been opened
• [x] I have checked the commit log to see if the issue has been resolved since my server was last updated
• [x] I have read the Contributing Guide
• [x] I have specified what branch this happens on branch: EDITME

Additional Information (Steps to reproduce/Expected behavior) : https://www.bg-wiki.com/ffxi/Quiescence:_Rune_Fencer_Guide https://www.bg-wiki.com/ffxi/Rune_Fencer_End-Game_Tank_Guide https://www.ffxiah.com/forum/topic/29127/random-question-thread-ffxi-related/190/#2318476 https://forum.square-enix.com/ffxi/archive/index.php/t-48460.html?s=0bff708324743ea11f85d3fcfce4aafb

Below is rune fencer runes, so opposite element. Aka fire row = ice element deubffs.

Fire - Ignis - Evasion Down / Paralyze / Frost / Bind Ice- Gelus - Defense Down / Gravity / Silence / Choke Earth- - Tellus - Magic Defense Down / Stun / Shock Thunder - Sulpor - Attack Down / Poison / Drown Wind- Flabra - Accuracy Down / Petrification / Rasp / Slow Water- Unda - Magic Attack Down / Amnesia // Plague / Addle / Burn Light - Lux - Magic Evasion Down / Dispel / Sleep / Blind Dark- Tenebrae - Magic Accuracy Down / Finale / Lullaby / Charm

Charm is currently Water(Should be Light) and Terror is currently Dark(Should be no element) Stuff like magic attack down, magic evasion down, magic accuracy down, accuracy defense down are wrong(Forget which exactly).

[TeoTwawki]

Warning: values for elemental ordering don't line up in multiple places in the client. As in the same number means a different element. And thats why the codebase has multiple arrays of it attempting to sync them up, even after refactorings trying to unify it. There are possibly artifacts form the last attempt at it back in topaz where some values weren't updated to match the changes. (audit is needed)

p.s. BG says terror status is earth based https://www.bg-wiki.com/ffxi/Terror

if this report was intended to specifically about rune fencer's abilities only (as in nothing rune fencer does will help it resist terror) that should be made clearer in the title and text body of the original comment.

[ShiyoKozuki]

Charm is water when it should be light. A bunch of debuffs related to mattk/mevasion/crit def down are also wrong element(or no element at all). Testing showed terror is not dark or earth , and maybe just can't be resisted by players.

I don't know why you'd say it's rune fencer only, rune fencer runes give resistances, it doesn't do anything special. Rune fencer is used as a reference since the guide has most of the elemental status effects listed.

[TeoTwawki]

I did not say it was, I said IF you meant something related to it then I didn’t understand right. I edited that in as an afterthought think I didn’t get things the 1st tile because so much of that post was rune fencer stuff which has only recently begin to get any work on it in the project and isn’t anywhere near done. I didn’t remember if RUN maybe had some special resisty things I was forgetting about either, so I hedged.

[TeoTwawki]

Lets make this simpler: show where in the project charm was mistakenly set as water element instead of light.

If you have bg wiki access might be worth your while to point out those tests on its talk page so that they don’t keep putting back the earth resistance notes.

[ShiyoKozuki]

https://github.com/LandSandBoat/server/blob/base/sql/status_effects.sql#L55 55 and 58

[TeoTwawki]

https://github.com/LandSandBoat/server/blob/base/sql/status_effects.sql#L55 55 and 58

Previously 6 was light ( fire was 0 instead of none) so like I figured it got fuddled by the resequencing

[TeoTwawki]

We’re lucky if anyone remembered to check mob element for xtals

[ShiyoKozuki]

Goblin tinkerers/fishers/anglers should drop lightning crystals but they drop fire! Rest should be fire.

WHERE do you edit crystal drops?

[TeoTwawki]

Goblin tinkerers/fishers/anglers should drop lightning crystals but they drop fire! Rest should be fire.

WHERE do you edit crystal drops?

mob family system table. Might be there needs to be 1 more goblin family or they just used wrong one because all goblins look the same to everyone :P

[ShiyoKozuki]

Element = crystal drop?

[TeoTwawki]

yes sorry if that wasn't clear in my earlier post