Language-Research-Technology / crate-o

Crate-O is a browser-based editor for Research Object Crates (RO-Crate)
https://language-research-technology.github.io/crate-o/
GNU General Public License v3.0
6 stars 2 forks source link

Bugs from testing RO-Crate creation #125

Closed rosanna-smith closed 6 months ago

rosanna-smith commented 6 months ago

These are some of the bugs/questions River, Otis and I ran into creating an RO-Crate for the Deafblind corpus (using the mode Language Data Commons top level Collection (corpus):

r-tae commented 6 months ago

Also there's a field 'Citation', the description is "Associated publications". I have a list of publications that reference the corpus, is this the proper place for that?

Never mind, Rosanna sent me documentation about it on Slack

r-tae commented 6 months ago

Re: the organisation lookup

I checked on my local version (up-to-date with main), there is debouncing its just the lookup can take up to 15s, which means just debouncing isn't enough.

You can see in my example that the middle request resolves last and I end up with no monash results. CleanShot 2024-05-09 at 11 15 44

It would be fixable if we could cancel in-flight requests, but I don't understand the code well enough to do that (and promises aren't cancellable by themselves so it isn't a particularly quick change)

rosanna-smith commented 6 months ago

Question about this section @ptsefton: When creating people, e.g. authors etc. should the ORCID be included in the description or is there another section for this?

I checked the language data commons top level and for author we have @id, @type, Name and Description. Should the ORCID go in the description field or in @id? The tooltip for @id just says Uniquie ID, but it's not one of the tooltips I can edit in the mode.

ptsefton commented 6 months ago

ORCID if available should go in @id for people

--

From: Rosanna @.> Date: Thursday, 16 May 2024 at 11:21 am To: Language-Research-Technology/crate-o @.> Cc: Peter Sefton @.>, Mention @.> Subject: Re: [Language-Research-Technology/crate-o] Bugs from testing RO-Crate creation (Issue #125)

Question about this section @ptseftonhttps://github.com/ptsefton: When creating people, e.g. authors etc. should the ORCID be included in the description or is there another section for this?

I checked the language data commons top level and for author we have @idhttps://github.com/id, @typehttps://github.com/type, Name and Description. Should the ORCID go in the description field or in @idhttps://github.com/id? The tooltip for @idhttps://github.com/id just says Uniquie ID, but it's not one of the tooltips I can edit in the mode.

— Reply to this email directly, view it on GitHubhttps://github.com/Language-Research-Technology/crate-o/issues/125#issuecomment-2113732281, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAFYTWCWRLQ3ZMZCIAM4F3DZCQCX7AVCNFSM6AAAAABHN453MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJTG4ZTEMRYGE. You are receiving this because you were mentioned.Message ID: @.***>

ptsefton commented 6 months ago

We may need to get our own copy of the ROR data and provide a faster lookup

--

From: River @.> Date: Thursday, 9 May 2024 at 11:21 am To: Language-Research-Technology/crate-o @.> Cc: Peter Sefton @.>, Assign @.> Subject: Re: [Language-Research-Technology/crate-o] Bugs from testing RO-Crate creation (Issue #125)

Re: the organisation lookup

I checked on my local version (up-to-date with main), its just the lookup is very slow (on my network at least) and it doesn't cancel in-flight requests if you type more.

You can see in my example that the middle request resolves last and I end up with no monash results. CleanShot.2024-05-09.at.11.15.44.gif (view on web)https://github.com/Language-Research-Technology/crate-o/assets/22485304/b8136df4-d7b2-4b05-a66a-52833cdf5e7e

— Reply to this email directly, view it on GitHubhttps://github.com/Language-Research-Technology/crate-o/issues/125#issuecomment-2101755058, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAFYTWCAKCNDKTJ3DL6EZSTZBLFSNAVCNFSM6AAAAABHN453MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRG42TKMBVHA. You are receiving this because you were assigned.Message ID: @.***>

ptsefton commented 6 months ago

Yes

--

From: River @.> Date: Thursday, 9 May 2024 at 10:57 am To: Language-Research-Technology/crate-o @.> Cc: Peter Sefton @.>, Assign @.> Subject: Re: [Language-Research-Technology/crate-o] Bugs from testing RO-Crate creation (Issue #125)

Also there's a field 'Citation', the description is "Associated publications". I have a list of publications that reference the corpus, is this the proper place for that?

— Reply to this email directly, view it on GitHubhttps://github.com/Language-Research-Technology/crate-o/issues/125#issuecomment-2101734546, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAFYTWHEYATMXIOHV4XC43DZBLCWPAVCNFSM6AAAAABHN453MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRG4ZTINJUGY. You are receiving this because you were assigned.Message ID: @.***>

r-tae commented 6 months ago

Perfect, thanks @ptsefton ! I believe I have enough to finalise both the Australian Deafblind Signing and Auslan Corpora

rosanna-smith commented 6 months ago

Marking as closed since @alvinsw will be updating the description of the @id in Crate-O. (thanks!)